Merged
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 90.62% 91.85% +1.22%
==========================================
Files 10 11 +1
Lines 1408 1620 +212
==========================================
+ Hits 1276 1488 +212
Misses 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…e/aieng-platform into add_complete_offboard_cmd
…e/aieng-platform into add_complete_offboard_cmd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
offboard-userssubcommand to theonboard adminCLI tool, enabling administrators to offboard Coder users who are no longer members of a specified GitHub organization. The implementation includes comprehensive CLI argument parsing, integration with the offboarding logic, and a full suite of tests to ensure correct behavior and argument handling.New CLI functionality:
offboard-userssubcommand tosrc/aieng_platform_onboard/admin/cli.py, with arguments to control organization, dry-run mode, account suspension, workspace and Firestore cleanup, and error handling options.offboard_users_from_orgfunction, passing through all relevant arguments.offboard_users_from_orgfunction for use in the CLI.Testing:
TestOffboardUsersCommandintests/aieng_platform_onboard/admin/test_cli.py, covering all CLI argument combinations, error cases, and help output for the newoffboard-userscommand.