Open
Conversation
rkennedy
requested changes
Aug 4, 2020
Collaborator
rkennedy
left a comment
rkennedy
left a comment
There was a problem hiding this comment.
The code looks fine. Everything could use a little cleanup, though. Please remove the .DS_Store file from the PR.
| Also, returns all the NetBackup jobs of the jobType 'Backup' | ||
|
|
||
|
|
||
| #######Use following command to execute the program |
Collaborator
There was a problem hiding this comment.
Please use markdown to format the readme. For example, # designates headings and indentation or backticks designate code.
| //############################################################## | ||
| func GetHTTPClient() *http.Client { | ||
| tlsConfig := &tls.Config { | ||
| InsecureSkipVerify: true, //for this test, ignore ssl certificate |
Collaborator
There was a problem hiding this comment.
Not just for this test. It's pretty standard to disable certificate validation in all NetBackup communication because the certificate is self-signed and thus unverifiable anyway. I think you can just remove the comment because it's not really indicating anything special about this code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@adi-bhardwaj @kevinpat1987 @aayush13890 @kaustubh-walokar