python,poweshell,go example scripts for replication targets on DV#53
python,poweshell,go example scripts for replication targets on DV#53sdunakhe wants to merge 2 commits intoVeritasOS:masterfrom
Conversation
rkennedy
left a comment
rkennedy
left a comment
There was a problem hiding this comment.
Things could use a bit of cleanup.
A few syntax errors indicate that much of this code has never actually been run. As much as possible, let's try to provide working examples. Syntax errors don't inspire confidence that anything works.
| port = "1556" | ||
| storageUri = "storage/" | ||
| port = "1556" | ||
| storageUri = "storage/" |
There was a problem hiding this comment.
This file now uses a mix of tabs and spaces for indentation. Can you please fix it to be consistent? I thought gofmt was supposed to make this kind of comment unnecessary.
| "type": "diskPool", | ||
| "attributes": map[string]interface{}{ | ||
| "name":dpName, | ||
| "diskVolumes":map[string]interface{}[, |
There was a problem hiding this comment.
This comma looks like a syntax error. Am I mistaken?
| print("--------------------------------------------------------\n"); | ||
| print("-- This script requires Perl 5.20.2 or later --\n"); | ||
| print("--------------------------------------------------------\n"); | ||
| print("Executing this library requires some additional libraries like \n\t'LWP' \n\t'JSON'\ \n\t'Getopt'\ \n\n"); |
There was a problem hiding this comment.
This message is pointless. The use statements above already enforce this, so nobody running this script will ever see the message printed here unless they already have the required modules, in which case they don't need to be told again.
|
|
||
| sub print_disclaimer { | ||
| print("--------------------------------------------------------\n"); | ||
| print("-- This script requires Perl 5.20.2 or later --\n"); |
There was a problem hiding this comment.
I think require v5.20.2 is a more concise way of stating this.
| print("Please provide the value for 'nbmaster'"); | ||
| exit; |
There was a problem hiding this comment.
This and all the other error messages lack a trailing newline. Since you're requiring version 5.20, you may as well use say instead of print. Better yet, use die, which will print to stderr and exit non-zero for you.
| print("Please provide the value for 'nbmaster'"); | |
| exit; | |
| die "Please provide the value for 'nbmaster'\n; |
|
|
||
| my @dvid_split = @split /:/, $dvid | ||
| my $dvid_hex = sprintf "0x%02x", hex $dvid_hex[0]; | ||
| my $url = "$PROTOCOL$master_server:$NB_PORT/netbackup/storage/storage-servers/".$stsid."/disk-volumes/".$dvid_hex."/replication-targets"; |
There was a problem hiding this comment.
String interpolation is used for the first few variables, but not for the latter ones. Why the change?
| - perl get_all_replication_targets_on_dv.pl -nbmaster <master_server> -username <username> -password <password> -stsid <storage server id> -dvid <diskvolume id> -payload <payload file path> [-domainname <domain_name>] [-domaintype <domain_type>]; | ||
|
|
||
| Get replication target on diskvolume with specific replication target id | ||
| - perl get_replication_target_by_id_on_dv.pl -nbmaster <master_server> -username <username> -password <password> -stsid <storage server id> -dvid <diskvolume id> -payload <payload file path> [-domainname <domain_name>] [-domaintype <domain_type>]; | ||
|
|
||
| Delete replication target on diskvolume | ||
| - perl post_delete_replication_target_on_dv.pl -nbmaster <master_server> -username <username> -password <password> -stsid <storage server id> -dvid <diskvolume id> -payload <payload file path> [-domainname <domain_name>] [-domaintype <domain_type>]; |
There was a problem hiding this comment.
Lose the semicolons at the ends of the lines.
| [string]$nbmaster = $(throw "Please specify the name of NetBackup master server using -nbmaster parameter."), | ||
| [string]$username = $(throw "Please specify the user name using -username parameter."), | ||
| [string]$password = $(throw "Please specify the password using -password parameter.") | ||
| [string]$stsid = $(throw "Please specify the storage server identifier using -stsid parameter.") | ||
| [string]$dvid = $(throw "Please specify the diskvolume id using -dvid parameter.") |
There was a problem hiding this comment.
Some lines end with commas and some don't. Is there significance to that?
| if ([Net.ServicePointManager]::SecurityProtocol -notcontains 'Tls12') { | ||
| [Net.ServicePointManager]::SecurityProtocol += [Net.SecurityProtocolType]::Tls12 | ||
| } | ||
| }G |
There was a problem hiding this comment.
This G looks out of place.
| $del_rep_tgt_json = '{ | ||
| { |
There was a problem hiding this comment.
This isn't valid JSON. The first brace introduces an object, so the second brace needs an attribute name before it.
2 participants
python,poweshell,go example scripts for replication targets on DiskVolume (msdp or cc)