Skip to content

test: add unit tests for %ZONE% templating#1835

Merged
AndrewChubatiuk merged 2 commits intomasterfrom
vmd-merge-template-replace
Feb 20, 2026
Merged

test: add unit tests for %ZONE% templating#1835
AndrewChubatiuk merged 2 commits intomasterfrom
vmd-merge-template-replace

Conversation

@vrutkovs
Copy link
Copy Markdown
Collaborator

@vrutkovs vrutkovs commented Feb 19, 2026

Ensure that %ZONE% can be templated anywhere in VMCluster / VMAgent spec


Summary by cubic

Add unit tests for mergeSpecs to verify %ZONE% replacement and zone-specific overrides in VMCluster and VMAgent. Tests nodeSelector templating and retentionPeriod override.

Written for commit 4b4e459. Summary will update on new commits.

Ensure that %ZONE% can be templated anywhere in VMCluster / VMAgent spec
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/controller/operator/factory/vmdistributed/util_test.go">

<violation number="1" location="internal/controller/operator/factory/vmdistributed/util_test.go:106">
P2: The test expectation uses "zone-a" even though the zone name passed to mergeSpecs is "zone-b", so this test will fail if %ZONE% templating works correctly. Align the expected selector with the input zone name.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread internal/controller/operator/factory/vmdistributed/util_test.go
Comment thread internal/controller/operator/factory/vmdistributed/util_test.go Outdated
Co-authored-by: Andrii Chubatiuk <achubatiuk@victoriametrics.com>
Signed-off-by: Vadim Rutkovsky <roignac@gmail.com>
@AndrewChubatiuk AndrewChubatiuk merged commit 3f9213c into master Feb 20, 2026
7 of 8 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the vmd-merge-template-replace branch February 20, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants