test: add unit tests for %ZONE% templating#1835
Merged
AndrewChubatiuk merged 2 commits intomasterfrom Feb 20, 2026
Merged
Conversation
Ensure that %ZONE% can be templated anywhere in VMCluster / VMAgent spec
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="internal/controller/operator/factory/vmdistributed/util_test.go">
<violation number="1" location="internal/controller/operator/factory/vmdistributed/util_test.go:106">
P2: The test expectation uses "zone-a" even though the zone name passed to mergeSpecs is "zone-b", so this test will fail if %ZONE% templating works correctly. Align the expected selector with the input zone name.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: Andrii Chubatiuk <achubatiuk@victoriametrics.com> Signed-off-by: Vadim Rutkovsky <roignac@gmail.com>
AndrewChubatiuk
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that %ZONE% can be templated anywhere in VMCluster / VMAgent spec
Summary by cubic
Add unit tests for mergeSpecs to verify %ZONE% replacement and zone-specific overrides in VMCluster and VMAgent. Tests nodeSelector templating and retentionPeriod override.
Written for commit 4b4e459. Summary will update on new commits.