test: add dual axis chart spec coverage#296
Open
cat0825 wants to merge 1 commit into
Open
Conversation
cat0825
force-pushed
the
test/get-chart-spec-dual-axis
branch
from
9ce01f5 to
72c32ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it
Adds unit coverage for
getChartSpecWithContextwhenchartTypeisDual Axis Chart.The new test verifies that VMind's chart spec pipeline returns the expected VChart
commonspec, including the bar/line series, dual-axis field mapping, generated data values, and axis configuration.Fixes #222
Which issue(s) this PR fixes
Fixes #222
Special notes for your reviewer
Validation run locally with Node 18.20.8:
npx --yes node@18 ../../common/scripts/install-run-rush.js installnpx --yes node@18 ../../common/scripts/install-run-rushx.js test -- --runTestsByPath __tests__/unit/getChartSpecWithContext_dualAxis.test.tsI also ran
npx --yes node@18 ../../common/scripts/install-run-rushx.js compile; it fails on pre-existing workspace type-resolution/type errors unrelated to this test-only change, mostly unresolved workspace package types such as@visactor/generate-vchartand@visactor/chart-advisor.