Conversation
TEXT columns no longer include a size parameter in DDL output. Previously text(1) was generated which MySQL interprets as TINYTEXT. Closes #171
Values for binary/varbinary columns are now wrapped with SQLSRV_PARAM_IN and SQLSRV_ENC_BINARY metadata so sqlsrv_prepare does not attempt nvarchar conversion. Closes #170
Verifies that boolean values can be inserted into BIT(1) columns via the query builder, including explicit true/false and default values. Refs #172
When an alias is passed as a string value in the select array (e.g., ['col' => 'alias']), wrap it in ['alias' => value] before passing to addColumn() which expects ?array. Closes #173
fix: resolve MySQL TEXT mapping, MSSQL varbinary insert, and select alias TypeError
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
============================================
+ Coverage 88.99% 89.02% +0.02%
- Complexity 2301 2304 +3
============================================
Files 59 59
Lines 5770 5776 +6
============================================
+ Hits 5135 5142 +7
+ Misses 635 634 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge bug fixes from dev to main: TEXT→TINYTEXT mapping, MSSQL varbinary insert, and select() string alias TypeError.
Motivation
Three reported bugs affecting MySQL and MSSQL users. Fixes #171, #170, #173.
Changes
MySQLColumn: TEXT type outputs plaintextin DDL instead oftext(1)(TINYTEXT)MSSQLInsertBuilder: binary/varbinary values bound with correct SQLSRV binary type metadataSelectExpression::select(): string alias values handled without TypeErrorHow to Test / Verify
Requires MySQL and MSSQL test containers.
Breaking Changes and Migration Steps
None
Checklist
Related issues
Closes #171, Closes #170, Closes #173