[GStreamer][Broadcom] fix incorrect casting of GstGhostPad to GstElement #1596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is observed when brcm audio/video filters are plugged into the "inner-parser" in WebKitThunderParser. The setupBufferingPercentageCorrection tries and fails to cast GstGhostPad to GstElement. The gst_pad_get_parent_element fits better for the use case. Also, this change disables the correction of buffering percentage for MSE and MediaStream playbacks.
Member
|
The PR looks good. Submitted it upstream for review as https://bugs.webkit.org/show_bug.cgi?id=305788 / WebKit/WebKit#56849. |
eocanha
added
the
upstream
Member
|
Patch landed upstream as WebKit/WebKit@c4980bb and backported to wpe-2.46 as f5afad2. Closed PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is observed when brcm audio/video filters are plugged into the "inner-parser" in WebKitThunderParser. The
setupBufferingPercentageCorrection tries and fails to cast GstGhostPad to GstElement. The gst_pad_get_parent_element fits better for the use case.
Also, this change disables the correction of buffering percentage for MSE and MediaStream playbacks.