Skip to content

CSS: Improve token value compute cache #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sirreal wants to merge 2 commits into
base: trunk
Choose a base branch
from
+9 −9
Draft

CSS: Improve token value compute cache #230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44bd7c0
The token_value is never float
sirreal Apr 8, 2026
33f7c24
Improve caching of computed token values
sirreal Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions components/DataLiberation/CSS/class-cssprocessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,15 +266,15 @@ class CSSProcessor {
private $token_value_length = null;

/**
* The string value of the current token.
* A cache for the decoded and normalized token value.
*
* For numbers, this is a float.
* For identifiers/functions/strings/URLs with escapes, this is a decoded string.
* Otherwise, it's null and the value is computed from token indices.
* - `false` indicates the has not been computed.
* - `null` is used for token types without an associated value will have `null`: whitespace, bad-url, comment, punctuation, etc.
* - `string` is used for token types with an associated value: ident, string, function, url, etc.
*
* @var string|float|null
* @var string|null|false
*/
private $token_value = null;
private $token_value = false;

/**
* The unit of the current token, e.g. "px", "em", "deg", etc.
Expand Down Expand Up @@ -671,8 +671,8 @@ public function get_unnormalized_token(): ?string {
* @see https://www.w3.org/TR/css-syntax-3/#token-value
* @return string|null
*/
public function get_token_value() {
if ( null === $this->token_value ) {
public function get_token_value(): ?string {
if ( false === $this->token_value ) {
if ( null === $this->token_starts_at || null === $this->token_length ) {
return null;
}
Expand Down Expand Up @@ -979,7 +979,7 @@ private function after_token(): void {
$this->token_type = null;
$this->token_starts_at = null;
$this->token_length = null;
$this->token_value = null;
$this->token_value = false;
$this->token_unit = null;
$this->token_value_starts_at = null;
$this->token_value_length = null;
Expand Down
Loading