Skip to content

Conversation

@ernilambar
Copy link
Member

Issue

This is a pretty edge case. When contributors have a trailing comma, the code incorrectly triggers a readme_invalid_contributors error for valid contributors:

Minimal example:

Contributors: username1, username2, username3,

Meta handles this correctly. This PR brings parity with Meta.

This PR:

  • Fixes the trim logic to properly handle trailing commas and spaces
  • Adds a test case to verify contributors with trailing commas are handled correctly

@ernilambar ernilambar force-pushed the fix-contributors-check branch from 57c2824 to 4349698 Compare January 2, 2026 07:16
@ernilambar ernilambar force-pushed the fix-contributors-check branch from 4349698 to 9b9227b Compare January 2, 2026 07:34
@ernilambar ernilambar marked this pull request as ready for review January 2, 2026 07:38
@github-actions
Copy link

github-actions bot commented Jan 2, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <nilambar@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: frantorres <frantorres@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar added this to the 1.9.0 milestone Jan 2, 2026
@ernilambar ernilambar merged commit d578a61 into trunk Jan 2, 2026
28 checks passed
@ernilambar ernilambar deleted the fix-contributors-check branch January 2, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants