Skip to content

Functions: Optimize wp_normalize_path(). #10781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
dmsnell wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Functions: Optimize wp_normalize_path(). #10781

dmsnell wants to merge 2 commits into from
+112 −13

Conversation

@dmsnell
Copy link
Member

@dmsnell dmsnell commented Jan 23, 2026 •
edited
Loading

In addition to optimizing, two changes were introduced:

  • The scheme separators for non-registered stream wrappers
    will be presered. Previously, these were combined into
    a single slash.

  • Windows drive letters which are not found at the start
    of the string will be upper-cases if they are not.
    Previously, if a drive letter were found after the first
    character and was lower-case, it would remain lower-case.

@dmsnell dmsnell force-pushed the functions/optimize-wp-normalize-path branch from 6e218df to e939742 Compare January 23, 2026 05:59
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 23, 2026
@dmsnell @josephscott
Functions: Optimize wp_normalize_path(). (WordPress#10781)
d3b2c00 
In addition to optimizing, two changes were introduced:

 - The scheme separators for non-registered stream wrappers
   will be presered. Previously, these were combined into
   a single slash.

 - Windows drive letters which are not found at the start
   of the string will be upper-cases if they are not.
   Previously, if a drive letter were found after the first
   character and was lower-case, it would remain lower-case.

Co-Authored-By: Joseph Scott <josephscott@git.wordpress.org>
Github-PR: 10781
Github-PR-Url: WordPress#10781
Git-Branch: functions/optimize-wp-normalize-path
@dmsnell dmsnell force-pushed the functions/optimize-wp-normalize-path branch from e939742 to 346bef9 Compare January 23, 2026 05:59
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 23, 2026
@dmsnell @josephscott
Functions: Optimize wp_normalize_path(). (WordPress#10781)
346bef9 
In addition to optimizing, two changes were introduced:

 - The scheme separators for non-registered stream wrappers
   will be presered. Previously, these were combined into
   a single slash.

 - Windows drive letters which are not found at the start
   of the string will be upper-cases if they are not.
   Previously, if a drive letter were found after the first
   character and was lower-case, it would remain lower-case.

Co-Authored-By: Joseph Scott <josephscott@git.wordpress.org>
Github-PR: 10781
Github-PR-Url: WordPress#10781
Git-Branch: functions/optimize-wp-normalize-path
@github-actions
Copy link

github-actions bot commented Jan 23, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 23, 2026
@dmsnell @josephscott
Functions: Optimize wp_normalize_path(). (WordPress#10781)
ab0d06c 
In addition to optimizing, two changes were introduced:

 - The scheme separators for non-registered stream wrappers
   will be presered. Previously, these were combined into
   a single slash.

 - Windows drive letters which are not found at the start
   of the string will be upper-cases if they are not.
   Previously, if a drive letter were found after the first
   character and was lower-case, it would remain lower-case.

Co-Authored-By: Joseph Scott <josephscott@git.wordpress.org>
Github-PR: 10781
Github-PR-Url: WordPress#10781
Git-Branch: functions/optimize-wp-normalize-path
@dmsnell dmsnell force-pushed the functions/optimize-wp-normalize-path branch from 346bef9 to ab0d06c Compare January 23, 2026 06:13
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 23, 2026
@dmsnell @josephscott
Functions: Optimize wp_normalize_path(). (WordPress#10781)
d064ac9 
In addition to optimizing, two changes were introduced:

 - The scheme separators for non-registered stream wrappers
   will be presered. Previously, these were combined into
   a single slash.

 - Windows drive letters which are not found at the start
   of the string will be upper-cases if they are not.
   Previously, if a drive letter were found after the first
   character and was lower-case, it would remain lower-case.

Co-Authored-By: Joseph Scott <josephscott@git.wordpress.org>
Github-PR: 10781
Github-PR-Url: WordPress#10781
Git-Branch: functions/optimize-wp-normalize-path
@dmsnell dmsnell force-pushed the functions/optimize-wp-normalize-path branch from ab0d06c to d064ac9 Compare January 23, 2026 07:19
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 23, 2026
@dmsnell @josephscott
Functions: Optimize wp_normalize_path(). (WordPress#10781)
4f66df2 
In addition to optimizing, two changes were introduced:

 - The scheme separators for non-registered stream wrappers
   will be presered. Previously, these were combined into
   a single slash.

 - Windows drive letters which are not found at the start
   of the string will be upper-cases if they are not.
   Previously, if a drive letter were found after the first
   character and was lower-case, it would remain lower-case.

Co-Authored-By: Joseph Scott <josephscott@git.wordpress.org>
Github-PR: 10781
Github-PR-Url: WordPress#10781
Git-Branch: functions/optimize-wp-normalize-path
@dmsnell dmsnell force-pushed the functions/optimize-wp-normalize-path branch from d064ac9 to 4f66df2 Compare January 23, 2026 07:20
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 23, 2026
@dmsnell @josephscott
Functions: Optimize wp_normalize_path(). (WordPress#10781)
95ad83b 
In addition to optimizing, two changes were introduced:

 - The scheme separators for non-registered stream wrappers
   will be presered. Previously, these were combined into
   a single slash.

 - Windows drive letters which are not found at the start
   of the string will be upper-cases if they are not.
   Previously, if a drive letter were found after the first
   character and was lower-case, it would remain lower-case.

Co-Authored-By: Joseph Scott <josephscott@git.wordpress.org>
Github-PR: 10781
Github-PR-Url: WordPress#10781
Git-Branch: functions/optimize-wp-normalize-path
@dmsnell dmsnell force-pushed the functions/optimize-wp-normalize-path branch from 4f66df2 to 95ad83b Compare January 23, 2026 07:36
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 23, 2026
@dmsnell @josephscott
Functions: Optimize wp_normalize_path(). (WordPress#10781)
dd0edf7 
In addition to optimizing, two changes were introduced:

 - The scheme separators for non-registered stream wrappers
   will be presered. Previously, these were combined into
   a single slash.

 - Windows drive letters which are not found at the start
   of the string will be upper-cases if they are not.
   Previously, if a drive letter were found after the first
   character and was lower-case, it would remain lower-case.

Co-Authored-By: Joseph Scott <josephscott@git.wordpress.org>
Github-PR: 10781
Github-PR-Url: WordPress#10781
Git-Branch: functions/optimize-wp-normalize-path
@dmsnell dmsnell force-pushed the functions/optimize-wp-normalize-path branch from 95ad83b to dd0edf7 Compare January 23, 2026 07:39
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 23, 2026
@dmsnell @josephscott
Functions: Optimize wp_normalize_path(). (WordPress#10781)
bfa9ae6 
In addition to optimizing, two changes were introduced:

 - The scheme separators for non-registered stream wrappers
   will be presered. Previously, these were combined into
   a single slash.

 - Windows drive letters which are not found at the start
   of the string will be upper-cases if they are not.
   Previously, if a drive letter were found after the first
   character and was lower-case, it would remain lower-case.

Co-Authored-By: Joseph Scott <josephscott@git.wordpress.org>
Github-PR: 10781
Github-PR-Url: WordPress#10781
Git-Branch: functions/optimize-wp-normalize-path
@dmsnell dmsnell force-pushed the functions/optimize-wp-normalize-path branch from dd0edf7 to bfa9ae6 Compare January 23, 2026 08:07
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 23, 2026
@dmsnell @josephscott
Functions: Optimize wp_normalize_path(). (WordPress#10781)
6f22615 
In addition to optimizing, two changes were introduced:

 - The scheme separators for non-registered stream wrappers
   will be presered. Previously, these were combined into
   a single slash.

 - Windows drive letters which are not found at the start
   of the string will be upper-cases if they are not.
   Previously, if a drive letter were found after the first
   character and was lower-case, it would remain lower-case.

Co-Authored-By: Joseph Scott <josephscott@git.wordpress.org>
Github-PR: 10781
Github-PR-Url: WordPress#10781
Git-Branch: functions/optimize-wp-normalize-path
@dmsnell dmsnell force-pushed the functions/optimize-wp-normalize-path branch 2 times, most recently from 6f22615 to 0a2b446 Compare January 23, 2026 08:38
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 23, 2026
@dmsnell @josephscott
Functions: Optimize wp_normalize_path(). (WordPress#10781)
0a2b446 
In addition to optimizing, two changes were introduced:

 - The scheme separators for non-registered stream wrappers
   will be presered. Previously, these were combined into
   a single slash.

 - Windows drive letters which are not found at the start
   of the string will be upper-cases if they are not.
   Previously, if a drive letter were found after the first
   character and was lower-case, it would remain lower-case.

Co-Authored-By: Joseph Scott <josephscott@git.wordpress.org>
Github-PR: 10781
Github-PR-Url: WordPress#10781
Git-Branch: functions/optimize-wp-normalize-path
@dmsnell dmsnell force-pushed the functions/optimize-wp-normalize-path branch from 0a2b446 to 6ff0541 Compare January 23, 2026 09:13
dmsnell added a commit to dmsnell/wordpress-develop that referenced this pull request Jan 23, 2026
@dmsnell @josephscott
Functions: Optimize wp_normalize_path(). (WordPress#10781)
6ff0541 
In addition to optimizing, two changes were introduced:

 - The scheme separators for non-registered stream wrappers
   will be presered. Previously, these were combined into
   a single slash.

 - Windows drive letters which are not found at the start
   of the string will be upper-cases if they are not.
   Previously, if a drive letter were found after the first
   character and was lower-case, it would remain lower-case.

Co-Authored-By: Joseph Scott <josephscott@git.wordpress.org>
Github-PR: 10781
Github-PR-Url: WordPress#10781
Git-Branch: functions/optimize-wp-normalize-path
@dmsnell @josephscott
Functions: Optimize wp_normalize_path(). (WordPress#10781)
5e88b26 
In addition to optimizing, two changes were introduced:

 - The scheme separators for non-registered stream wrappers
   will be presered. Previously, these were combined into
   a single slash.

 - Windows drive letters which are not found at the start
   of the string will be upper-cases if they are not.
   Previously, if a drive letter were found after the first
   character and was lower-case, it would remain lower-case.

Co-Authored-By: Joseph Scott <josephscott@git.wordpress.org>
Github-PR: 10781
Github-PR-Url: WordPress#10781
Git-Branch: functions/optimize-wp-normalize-path
@dmsnell dmsnell force-pushed the functions/optimize-wp-normalize-path branch from 6ff0541 to 5e88b26 Compare January 23, 2026 09:14
dmsnell
dmsnell commented Jan 23, 2026
View reviewed changes
src/wp-includes/functions.php
*/
function wp_normalize_path( $path ) {
$wrapper = '';
$path = (string) $path;
Copy link
Member Author

@dmsnell dmsnell Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be really good to eliminate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dmsnell