Admin UI: Reskin notices to align with WordPress Design System #10784
+63
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all notice styles to match Gutenberg's component patterns and the WordPress Design System specifications. **Base Notice Styles:** - Border: 4px left border only (removed generic border) - Box shadow: removed for cleaner appearance - Padding: 8px 12px (was 1px 12px) - Typography: 13px/20px, color #1e1e1e (gray-900) **Notice Type Colors:** - Info: #3858e9 border, transparent background - Success: #4ab866 border, #eff9f1 background - Warning: #f0b849 border, #fef8ee background - Error: #cc1818 border, #fcf0f0 background **Dismiss Button:** - Size: 24px × 24px (was 20px × 20px) - Position: top 8px, right 12px (improved alignment) - Color: #1e1e1e (was #787c82) - Icon size: 20px/24px (was 16px/20px) - Focus: Gutenberg-style ring using var(--wp-admin-theme-color) - Hover: opacity 0.7 **Links in Notices:** - Color: var(--wp-admin-theme-color) - Hover: var(--wp-admin-theme-color-darker-10) - Focus: proper focus ring with var(--wp-admin-border-width-focus) **Spacing:** - Dismissible notices: 48px right padding (was 38px) - Provides 24px gap between content and dismiss button See: https://core.trac.wordpress.org/ticket/64308
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/64548
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.