Skip to content

iAPI: align server-side negation truthiness with client side #11804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shrivastavanolo wants to merge 1 commit into
base: trunk
Choose a base branch
from
+9 −1
Open

iAPI: align server-side negation truthiness with client side #11804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/wp-includes/interactivity-api/class-wp-interactivity-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,15 @@ private function evaluate( $entry ) {
}

// Returns the opposite if it contains a negation operator (!).
return $should_negate_value ? ! $current : $current;
// Uses JavaScript-compatible truthiness rules to ensure server and client
// rendering agree. PHP and JavaScript differ on two values:
// - [] (empty array): falsy in PHP, truthy in JavaScript.
// - '0' (string zero): falsy in PHP, truthy in JavaScript.
if ( $should_negate_value ) {
$is_truthy = is_array( $current ) || '0' === $current ? true : (bool) $current;
return ! $is_truthy;
}
return $current;
}

/**
Expand Down
Loading