Enhance show_message function with optional echo parameter and tests#11807
Enhance show_message function with optional echo parameter and tests#11807shreyasikhar wants to merge 3 commits into
Conversation
…rameter and add corresponding unit tests Co-authored-by: Copilot <copilot@github.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This pull request updates the
show_messagefunction insrc/wp-admin/includes/misc.phpto add support for returning the formatted message as a string instead of always printing it.Without this change, it is almost impossible to add tests for this
show_messagefunction because of buffer flushing functions called at the end of it's definition.Enhancements to message display:
show_messagefunction to accept a new$echoparameter (defaulting totrue). When$echoisfalse, the function returns the formatted HTML string instead of printing it and flushing output buffers. The function signature and docblock were updated accordingly.Testing improvements:
Tests_Admin_Includes_Misc_ShowMessage_Testintests/phpunit/tests/admin/includes/misc/ShowMessage_Test.phpto verify thatshow_messagecorrectly returns the formatted HTML string for plain messages andWP_Errorobjects when$echoisfalse.Trac ticket: https://core.trac.wordpress.org/ticket/65181