Skip to content

Admin: Fix plugin card overlap with localized install actions on Add Plugins#11820

Open
itzmekhokan wants to merge 2 commits into
WordPress:trunkfrom
itzmekhokan:fix/64686-plugin-card-overlap
Open

Admin: Fix plugin card overlap with localized install actions on Add Plugins#11820
itzmekhokan wants to merge 2 commits into
WordPress:trunkfrom
itzmekhokan:fix/64686-plugin-card-overlap

Conversation

@itzmekhokan
Copy link
Copy Markdown

Fixes layout on Plugins → Add New where long translated strings for the install/update action (e.g. Japanese, Bengali, German, French) could overlap the plugin title and description. Compact buttons alone did not fully resolve this for all locales and widths (PR #11021, reopened in Trac).

Approach

  • Wide viewports (≥1101px): Position .plugin-card .action-links under the plugin icon (top / left / fixed width) so labels stay in the icon column instead of intruding on the text column; remove the large margin-right reserve on .name / .desc > p that fought absolute positioning.
  • Tablet / small breakpoints (existing max-width: 1100px + (min-width: 782px) or max-width: 480px query): Give static .action-links full remaining width (calc(100% - 148px)) and reset .desc > p left margin so the description area can use space more sensibly.
    CSS only: src/wp-admin/css/list-tables.css (no PHP/HTML).

Trac ticket: https://core.trac.wordpress.org/ticket/64686

Avoids overlap between long localized button labels and the plugin title or description. Props 369work.

See #64686.
Use full remaining width for static action links and reset description margin for clearer layout.

See #64686.
@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these proposed changes, the links overlap content in new places.

Links on top of the thumbnail image at 1200 pixels wide:

1200 pixels wide

Thumbnail images on top of description paragraphs at 1000 pixels:

1000 pixels wide

Buttons with transparent background on top of long plugin names at 560 pixels:

560 pixels wide

I think the suggestion in the ticket involved either replacing some of the current rules or adding the new rules later in list-tables.css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants