Disconnect kafka consumers on sigterm#441
Open
nikossaravanos-workable wants to merge 1 commit intomasterfrom
Open
Disconnect kafka consumers on sigterm#441nikossaravanos-workable wants to merge 1 commit intomasterfrom
nikossaravanos-workable wants to merge 1 commit intomasterfrom
Conversation
nikossaravanos-workable
requested review from
echetzakis,
jgerbe,
klesgidis,
kzacharakis,
nikosd23 and
stavros-wb
as code owners
jgerbe
reviewed
Feb 11, 2026
| authenticationTimeout | ||
| }); | ||
| const consumer = this.consumeClient.consumer({ groupId, ...rest }); | ||
| this.consumers.set(groupId, consumer); |
Contributor
There was a problem hiding this comment.
❓ could you elaborate please?
Contributor
Author
There was a problem hiding this comment.
This map is used here handleSigterm.
In order to handle SIGTERM and signal all consumers to stop consuming messages, process the ongoing messages and commit the offsets we need to keep a reference to all consumers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.