Skip to content

modernize docs, tests, with a ci flow#23

Merged
eschultink merged 1 commit intomainfrom
modernize
Feb 25, 2026
Merged

modernize docs, tests, with a ci flow#23
eschultink merged 1 commit intomainfrom
modernize

Conversation

@eschultink
Copy link
Member

  • modernize everything, CI tests, etc.

Change implications

  • includes or requires infrastructure changes? No infrastructure changes are included or required in this pull request.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modernizes the codebase by updating tests, documentation, and CI infrastructure. The changes improve error handling in the validateFrequency function by making it throw errors instead of just logging, add comprehensive test coverage for this behavior, enhance documentation with usage guidance, and modernize the GitHub Actions workflow with multi-version Node.js testing.

Changes:

  • Enhanced validateFrequency to throw errors when invalid frequencies are provided, with corresponding test coverage
  • Added AGENTS.md documentation file explaining repository structure and purpose for AI agents
  • Modernized GitHub Actions CI workflow with newer action versions (v4), Node.js matrix testing (20.x, 22.x, 24.x, 25.x), and additional workflow triggers
  • Updated README with guidance on when to use this tool versus native Firestore scheduled backups
  • Applied consistent code formatting throughout test files

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/cmd.js Added test coverage for validateFrequency function's error throwing behavior and applied consistent code formatting
lib/cmd.js Enhanced validateFrequency to throw errors instead of only logging to console, improving error handling
README.md Added note clarifying this tool is for backing up subset of entities, not entire databases
AGENTS.md New documentation file explaining repository structure, purpose, and technical details for AI agents
.github/workflows/test.yml Modernized CI with actions v4, Node.js version matrix (20.x-25.x), and additional triggers (pull_request, workflow_dispatch)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eschultink eschultink merged commit 413e8fe into main Feb 25, 2026
15 checks passed
@eschultink eschultink deleted the modernize branch February 25, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants