[src/{bin/main,global,lib}.rs] Add new additional_derives vec CLI opt…#145
Open
SamuelMarks wants to merge 8 commits intoWulf:mainfrom
Open
[src/{bin/main,global,lib}.rs] Add new additional_derives vec CLI opt…#145SamuelMarks wants to merge 8 commits intoWulf:mainfrom
additional_derives vec CLI opt…#145SamuelMarks wants to merge 8 commits intoWulf:mainfrom
Conversation
…ption ; [src/code.rs] Fix type elision warning
hasezoey
requested changes
Sep 5, 2025
Collaborator
hasezoey
left a comment
There was a problem hiding this comment.
Thanks for this change, this was likely overdue.
Though there are some extra changes that should be done:
- the commit message style we use is conventional/angular (though with the scope of this PR, i might just squash and change the message myself)
- add tests for this new option (see existing tests for examples)
- remove the
Optionwrapping as listed in the comments below
hasezoey
requested changes
Sep 6, 2025
Collaborator
hasezoey
left a comment
There was a problem hiding this comment.
Looks better, tests are still missing though. See simple_table_sqlite for a simple example.
hasezoey
reviewed
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
; [src/code.rs] Fix type elision warning
Basically I am getting this issue:
utoipa::ToSchemaneeds to be on thestruct. But it's a bit too specific to make it to this library/cli, and regardless doesn't futureproof dsync.So this just lets you add arbitrary derives as strings. As many as your heart desires.
--help