Merged
Conversation
- Move concrete implementation to new TBaseFileInfoExtractor class - Make IFileInfoExtractor pure interface with abstract methods - TVimFileInfoExtractor now inherits from TBaseFileInfoExtractor - Improves SOLID compliance and separation of concerns
- Rename ICodeRunnerBuilder to ICodeRunnerFactory - Rename TVimCodeRunnerBuilder to TVimCodeRunnerFactory - Rename build() method to create() - Rename all _build_* private methods to _create_* - Factory pattern better reflects single-call object creation - All 87 tests passing
- Prevent passing filenames to ruff, ruff_format, mypy, pylint - Hooks now check entire python_coderunner directory - Improves hook execution consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.