[WIP] Prerender stats pages for faster production builds#85
Open
[WIP] Prerender stats pages for faster production builds#85
Conversation
Member
|
I've added the admin secret of the production instance of Hasura to the environment variables of the production instance of the app (as |
Contributor
Author
Thanks a lot 🙏 |
3563206 to
3227048
Compare
Contributor
Author
|
This works well in production build mode but freezes the dev build. The problem that this PR would help solve is already being well mitigated by #84. I will not merge this for now until I find a solution to the dev build freeze problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is motivated by the fact that statistics can be time intensive to process and don't need to be realtime accurate.
NextJS allows us to pre-render a page with data fetched at build time, data is then refetched every X seconds (I set 5 minutes in this case). This is a nice solution to make stats pages blazing fast 🚀
@hgwood: FYI since it's the nextjs server that executes the fetching this is going to require access to hasura admin secret in production