Skip to content

Conversation

@mathk
Copy link
Collaborator

@mathk mathk commented Jan 19, 2026

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 7 issues on changed lines in 1 file:

  • port/stmicro/stm32/src/hals/STM32F303/rcc.zig: 7 issues

@mathk mathk force-pushed the stm32F303-clocktree branch from ba9e5e4 to b1266cd Compare January 20, 2026 10:06
@github-actions github-actions bot dismissed their stale review January 20, 2026 10:06

Updating with new lint results

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 7 issues on changed lines in 1 file:

  • port/stmicro/stm32/src/hals/STM32F303/rcc.zig: 7 issues

@mathk mathk requested a review from Grazfather January 20, 2026 14:49
@mathk mathk force-pushed the stm32F303-clocktree branch from b1266cd to 3567bf1 Compare January 23, 2026 08:11
@github-actions github-actions bot dismissed their stale review January 23, 2026 08:12

Updating with new lint results

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 2 issues on changed lines in 2 files:

  • port/stmicro/stm32/src/hals/STM32F303/rcc.zig: 1 issue
  • port/wch/ch32v/src/cpus/main.zig: 1 issue

⚠️ Could not attach inline comments due to an error.

@mathk mathk force-pushed the stm32F303-clocktree branch from 3567bf1 to 28e72b2 Compare January 23, 2026 11:22
@github-actions github-actions bot dismissed their stale review January 23, 2026 11:22

Updating with new lint results

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lint Results

Found 1 issue on changed lines in 1 file:

  • port/stmicro/stm32/src/hals/STM32F303/rcc.zig: 1 issue

Copy link
Collaborator

@Grazfather Grazfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few comments.

In the future, can you push extra commits, so that I can review just what you changed since your last push, rather than having to re-review everything?

@Grazfather Grazfather merged commit 4d3ddca into ZigEmbeddedGroup:main Jan 23, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants