UN-3159 [MISC] Add improved logging for retrieval operations #1747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add cache statistics logging to variable_replacement lru_cache (logs every 50 calls with hit rate, cache size) - Move retry logging in simple retriever to only log when actually retrying (not for initial attempts) - Optimize json_repair_helper with heuristic to skip double parsing when unnecessary - Add detailed retrieval metrics logging to services/retrieval.py for better observability Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThese changes enhance logging and instrumentation across retrieval and variable extraction modules. SimpleRetriever logging is adjusted for retry reporting, variable extraction introduces a caching layer with statistics tracking, and retrieval operations now capture and log timing metrics alongside contextual information. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
chandrasekharan-zipstack
requested review from
Deepak-Kesavan and
harini-venkataraman
chandrasekharan-zipstack
changed the title
prompt-service/src/unstract/prompt_service/utils/json_repair_helper.py
Outdated
Show resolved
Hide resolved
Remove the heuristic optimization - keeping only logging improvements in this PR. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Deepak-Kesavan
approved these changes
Jan 21, 2026
|
Contributor
Test ResultsSummary
Runner Tests - Full Report
SDK1 Tests - Full Report
|
chandrasekharan-zipstack
deleted the
feature/UN-3159-improve-retrieval-logging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How
retrieval.pyandsimple.pyto track retrieval operation flowvariable_replacement.pyto report hit rate, cache size, and prompt sizejson_repair_helper.pyto skip unnecessary double parsing when working with single JSON objectsCan this PR break any existing features. If yes, please list possible items. If no, please explain why.
No. These are additive changes that only add logging and a minor optimization. No API changes or data model modifications.
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
These changes should be tested by:
Screenshots