UNS-001 [FIX] Add SIGTERM trap handlers for graceful container shutdown #1750

ritwik-g · 2026-01-21T08:38:38Z

Summary

Add bash-level SIGTERM trap handlers to tool and sidecar container entrypoints
Prevent premature termination during container shutdown by intercepting SIGTERM signals
Allow containers to complete naturally via existing sentinel-based completion detection

Changes

runner/src/unstract/runner/runner.py: Add SIGTERM trap to dynamically generated tool container shell script
tool-sidecar/entrypoint.sh: Add SIGTERM handler function, remove exec to allow trap to fire, remove opentelemetry-instrument wrapper

How it works

When container orchestrators (Docker/Kubernetes) send SIGTERM:

The shell's trap catches the signal at PID 1
The trap logs the event and returns (doesn't exit)
The child process (tool or log processor) continues unaware of the signal
Natural completion flow via TOOL_EXECUTION_COMPLETE sentinel remains unchanged
Containers exit gracefully with proper exit codes

Test plan

Verify docker kill --signal=SIGTERM <container> logs the trap message
Confirm tool/sidecar continues to completion after SIGTERM
Check that sentinel-based completion detection still works
For Kubernetes, verify pods complete within the default 30s grace period

🤖 Generated with Claude Code

Add bash-level SIGTERM trap handlers to tool and sidecar container entrypoints to prevent premature termination during container shutdown. Changes: - runner.py: Add SIGTERM trap to tool container shell script that logs signal receipt but continues execution - entrypoint.sh: Add SIGTERM handler function, remove 'exec' to allow trap to fire, remove opentelemetry-instrument wrapper The traps intercept SIGTERM from container orchestrators (Docker/K8s) and log the event while allowing the containers to complete naturally via the existing sentinel-based completion detection mechanism. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

coderabbitai · 2026-01-21T08:38:57Z

Summary by CodeRabbit

Bug Fixes
- Enhanced termination signal handling to ensure graceful shutdown across the application.
- Improved shutdown flow to allow background processes to complete properly before application termination.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

Updates to signal handling in containerized execution. The runner.py adds a SIGTERM trap that logs signal receipt with timestamp before executing container commands. The entrypoint.sh introduces SIGTERM handler and replaces OpenTelemetry-instrumented invocation with direct Python execution.

Changes

Cohort / File(s)	Summary
Signal handling and graceful shutdown `runner/src/unstract/runner/runner.py`, `tool-sidecar/entrypoint.sh`	Added SIGTERM trap handlers that log signal acknowledgment and allow continued execution. Modified container command to register signal trap before executing other operations. Updated entrypoint to use direct Python invocation instead of OpenTelemetry-instrumented exec, enabling shell-level signal handling.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description comprehensively covers the What, Why, and How sections with clear explanations and test plans. However, critical sections from the template like 'Can this PR break any existing features', Database Migrations, Env Config, and others are not filled out as required.	Complete all required template sections, especially the 'Can this PR break any existing features' section which the template marks as required for admin merge approval. Address Database Migrations, Env Config, Dependencies Versions, and Related Issues sections.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: adding SIGTERM trap handlers for graceful container shutdown. It directly relates to the file modifications in both runner.py and entrypoint.sh.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-01-21T08:39:30Z

Test Results

Summary

✅ Runner Tests: 11 passed, 0 failed (11 total)
✅ SDK1 Tests: 66 passed, 0 failed (66 total)

Runner Tests - Full Report

filepath	function	$$\textcolor{#23d18b}{\tt{passed}}$$	SUBTOTAL
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_logs}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_cleanup}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_client\_init}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_get\_image}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_run\_container}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_get\_image\_for\_sidecar}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_sidecar\_container}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$		$$\textcolor{#23d18b}{\tt{11}}$$	$$\textcolor{#23d18b}{\tt{11}}$$

SDK1 Tests - Full Report

sonarqubecloud · 2026-01-21T08:39:41Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ritwik-g requested review from hari-kuriakose, jaseemjaskp, kirtimanmishrazipstack and muhammad-ali-e January 21, 2026 08:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

UNS-001 [FIX] Add SIGTERM trap handlers for graceful container shutdown #1750

UNS-001 [FIX] Add SIGTERM trap handlers for graceful container shutdown #1750

Uh oh!

ritwik-g commented Jan 21, 2026

Uh oh!

coderabbitai bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

sonarqubecloud bot commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

UNS-001 [FIX] Add SIGTERM trap handlers for graceful container shutdown #1750

Are you sure you want to change the base?

UNS-001 [FIX] Add SIGTERM trap handlers for graceful container shutdown #1750

Uh oh!

Conversation

ritwik-g commented Jan 21, 2026

Summary

Changes

How it works

Test plan

Uh oh!

coderabbitai bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Estimated code review effort

Uh oh!

github-actions bot commented Jan 21, 2026

Test Results

Uh oh!

sonarqubecloud bot commented Jan 21, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Jan 21, 2026 •

edited

Loading