Open
Conversation
tizisdeepan
commented
Jul 18, 2019
|
|
||
| t6.filter = SampleFilters.getNightWhisperFilter(); | ||
| ThumbnailsManager.addThumb(t6); | ||
| ThumbnailItem originalImage = new ThumbnailItem(); |
Author
There was a problem hiding this comment.
Had to redo the object instantiations in order to make the code better understanding. I have used the respective filter names for variables.
tizisdeepan
commented
Jul 18, 2019
| filter.addSubFilter(new ToneCurveSubFilter(rgbKnots, redKnots, greenKnots, blueKnots)); | ||
| return filter; | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
These are the recreated Instagram filters.
Author
|
The new filters are,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have recreated filters like in Instagram in SampleFilters.java