fix: Improve task_push_notification_config presence check.#1047
Open
fix: Improve task_push_notification_config presence check.#1047
Conversation
bartek-w
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the logic in both the default and V2 request handlers to use the Protobuf HasField method for checking the presence of task_push_notification_config. This change ensures that default, empty configurations do not incorrectly trigger push notification setup. A new test case was added to verify this behavior; however, the reviewer noted that the test name is misleading because it asserts that the method is not called, and suggested renaming it for clarity.
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/agent_execution/active_task.py | 96.29% | 96.48% | 🟢 +0.19% |
| Total | 93.01% | 93.01% | 🟢 +0.01% |
Generated by coverage-comment.yml
bartek-w
force-pushed
the
bartekw-empty-push
branch
from
d6278a9 to
72c5395
Compare
ishymko
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call _push_config_store.set_info only when task_push_notification_config is set.
Due to proto3 semantic bool(params.configuration.task_push_notification_config) was always True.
Fixes #1045 🦕