Refactor client action calls to use gen() method#629
Merged
Conversation
Adapt all demo apps to the new z2ui5_if_action interface: the client `action` method was replaced by an `action` interface reference exposing a `gen( )` method with the same signature. Calls now use `client->action->gen( )`. Note: abaplint reports these calls until the corresponding abap2UI5 framework change (new z2ui5_if_action interface) is merged into the default branch the samples lint against. https://claude.ai/code/session_0123tcSwjTWxoGTG6YossyaN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated all demo app classes to use the new
client->action->gen()method signature instead of the directclient->action()call. This refactoring standardizes the action invocation pattern across the codebase.Changes
client->action(...)toclient->action->gen(...)across 16 demo app classesz2ui5_cl_demo_app_362(scroll actions)z2ui5_cl_demo_app_189(focus actions)z2ui5_cl_demo_app_352(keyboard mode actions)z2ui5_cl_demo_app_s_03(audio playback)z2ui5_cl_demo_app_lp_02(launchpad title)z2ui5_cl_demo_app_000(documentation)z2ui5_cl_demo_app_129(timer actions)z2ui5_cl_demo_app_202(wizard navigation)z2ui5_cl_demo_app_315(OData model setup)z2ui5_cl_demo_app_320(popover navigation)z2ui5_cl_demo_app_325(clipboard actions)z2ui5_cl_demo_app_353(timer and focus)z2ui5_cl_demo_app_309(custom JavaScript)z2ui5_cl_demo_app_180(new tab opening)z2ui5_cl_demo_app_028(timer)z2ui5_cl_demo_app_071(size limit)z2ui5_cl_demo_app_121(timer)z2ui5_cl_demo_app_125(title setting)z2ui5_cl_demo_app_133(focus with selection)z2ui5_cl_demo_app_186(file download)z2ui5_cl_demo_app_323(clipboard app state)z2ui5_cl_demo_app_363(scroll into view)Implementation Details
All action invocations maintain the same parameter structure (
valandt_arg). The change is purely a method call refactoring to align with the updated client API interface.https://claude.ai/code/session_0123tcSwjTWxoGTG6YossyaN