Reset the polluted database to ensure some tests work as expected#941
Open
Wang-Benjamin wants to merge 1 commit intoabel533:masterfrom
Open
Reset the polluted database to ensure some tests work as expected#941Wang-Benjamin wants to merge 1 commit intoabel533:masterfrom
Wang-Benjamin wants to merge 1 commit intoabel533:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the execution order of tests are shuffled, if tests (polluters) that make modifications on the database run before tests (victims) that rely on the original/unmodified database, the database will be polluted and victim tests will fail with assertionError.
Involved tests:
The above are all order-dependent victim tests and they test the properties of database without modification.
Take
TestExistsWithPrimaryKey.testDynamicExistsWithPrimaryKeyas an example:It expects
countrywithid=35exists in the database but it actually fails with assertionError if polluter tests that delete/modify thecountrywithid=35in the database run before it.Proposed Fix
A simple and safe way to ensure victim tests can work as we expect is to reset/clean the database before executing such tests.
Glad to discuss this issue if you have concerns.