ci: GHA workflow security cleanup#339
Open
emptyhammond wants to merge 3 commits into
Open
Conversation
Set `persist-credentials: false` on all `actions/checkout` steps so the default `GITHUB_TOKEN` is not written to the local git config after checkout. Addresses a finding from a routine workflow audit. No behavioural change — these workflows do not push back to the repo using the auto-persisted credentials.
Add top-level `permissions: {}` to each workflow and grant each job
only the `GITHUB_TOKEN` scopes it actually uses (`contents: read`,
plus `id-token: write` where OIDC is needed to assume an AWS role).
Addresses a finding from a routine workflow audit.
No behavioural change — the same operations succeed with the
narrower scopes.
Pin every `uses:` reference to a commit SHA, preserving the existing major-version tag as a trailing comment. This stops an upstream tag move from silently changing what runs in CI. Addresses a finding from a routine workflow audit. No version bumps — each pinned SHA is the current head of the same major version tag the workflow already used.
lmars
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine hygiene pass over the GitHub Actions workflows in this repo, addressing findings from a workflow security audit. Changes are split into three commits, one per finding type:
where OIDC is used to assume an AWS role).
No behavioural changes intended - the workflows run the same steps against the same inputs, no version bumps.