Skip to content

Conversation

@kaschula
Copy link
Contributor

Summary

  • Add documentation for the new notification inband mode for LiveObjects
  • Reorganize the inband objects page to clearly distinguish between the two available modes
  • Add JSON examples for Counter and Map object message formats as the REST API reference they previously linked to have been removed.

Changes

New notification mode documentation:

  • Explains that notification mode sends a notification when an objects operation is received (not just when state changes)
  • Documents the message format with the link property for fetching state via REST API
  • Clarifies that no initial state is sent on attach
  • Provides usage guidance on when to use each mode

Improved objects mode documentation:

  • Reorganized existing content under a dedicated "Objects mode" section
  • Added concrete JSON examples showing the message format for both Counter and Map objects

Updated mode comparison table:

  • Added a comparison table at the top showing both objects and notification modes
  • Updated enable section to show how to configure either mode

Checklist

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ait-59-inband-docs-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kaschula kaschula requested a review from GregHolmes January 27, 2026 10:43
@GregHolmes GregHolmes force-pushed the ait-59-inband-docs-update branch from acd6ddc to 3316e53 Compare January 28, 2026 10:49
Copy link
Contributor

@GregHolmes GregHolmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real big issues here! A broken json example, and the rest are comments. Let me know what you think.

{
"name": "[meta]objects",
"data": {
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{

There's an extra { on this line.

## Subscribe to updates <a id="inband-objects-subscribe"/>

When using inband objects, the client will receive special `[meta]objects` messages whenever the objects on the channel are updated. These messages provide a snapshot of the current set of objects on the channel.
When using inband objects, the client will receive special `[meta]objects` messages whenever the objects on the channel are updated. The content of these messages depends on which mode you are using.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When using inband objects, the client will receive special `[meta]objects` messages whenever the objects on the channel are updated. The content of these messages depends on which mode you are using.
When using inband objects, the client will receive special `[meta]objects` messages whenever the objects on the channel are updated. The contents of these messages depends on which mode you are using.

## Subscribe to updates <a id="inband-objects-subscribe"/>

When using inband objects, the client will receive special `[meta]objects` messages whenever the objects on the channel are updated. These messages provide a snapshot of the current set of objects on the channel.
When using inband objects, the client will receive special `[meta]objects` messages whenever the objects on the channel are updated. The content of these messages depends on which mode you are using.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to know what these contents are here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll remove this line. Everything is explained below it adds nothing.


There are two inband modes available:

| Mode | Description |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Mode | Description |
| Mode | Description |
| --- | --- |
| `objects` | Sends the full state of all objects on the channel. |

This isn't a big issue, but you don't need to fill to match the size of the table. The above would do for the first 3 lines of the table. MDX will render it correctly either way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, my IDE insisted.

@kaschula kaschula force-pushed the ait-59-inband-docs-update branch from 3316e53 to 41cc3be Compare January 29, 2026 11:30
@kaschula kaschula requested a review from GregHolmes January 29, 2026 12:01
Document the new `notification` inband mode for LiveObjects which
notifies clients when objects operations are received without sending
the full state data.
@GregHolmes GregHolmes force-pushed the ait-59-inband-docs-update branch from 41cc3be to b4bfcb1 Compare February 8, 2026 21:35
We now stop sending inband object state sync if an object is over the max maessage size.
@kaschula
Copy link
Contributor Author

@GregHolmes Please could re-review I have updated the docs with some additional information a change that is due to be merged - 6e401e9

@kaschula kaschula requested a review from GregHolmes February 11, 2026 11:00
Copy link
Contributor

@GregHolmes GregHolmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaschula , I've added a fixup for a couple sentence change and adding a sentence between headers.

All approved.
Just need to squash fixup (I'll keep it in place atm for you to read)

@kaschula
Copy link
Contributor Author

Thanks @kaschula , I've added a fixup for a couple sentence change and adding a sentence between headers.

All approved. Just need to squash fixup (I'll keep it in place atm for you to read)

Thanks Greg, I have read them and it makes sense. Do you want me to do the rebase? I don't want to merge just yet till the fix rolls out in production next week.

@GregHolmes GregHolmes added the Do not merge When the PR is in progress do not merge label Feb 13, 2026
@GregHolmes
Copy link
Contributor

Thanks @kaschula , I've added a fixup for a couple sentence change and adding a sentence between headers.
All approved. Just need to squash fixup (I'll keep it in place atm for you to read)

Thanks Greg, I have read them and it makes sense. Do you want me to do the rebase? I don't want to merge just yet till the fix rolls out in production next week.

You're welcome to rebase to squash the fixup.
If not, I can do after the standup.

@kaschula
Copy link
Contributor Author

Thanks @kaschula , I've added a fixup for a couple sentence change and adding a sentence between headers.
All approved. Just need to squash fixup (I'll keep it in place atm for you to read)

Thanks Greg, I have read them and it makes sense. Do you want me to do the rebase? I don't want to merge just yet till the fix rolls out in production next week.

You're welcome to rebase to squash the fixup. If not, I can do after the standup.

I'll keep ownership and I will release it when the changes rollout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do not merge When the PR is in progress do not merge

Development

Successfully merging this pull request may close these issues.

2 participants