-
Notifications
You must be signed in to change notification settings - Fork 46
docs: Add notification inband mode for LiveObjects #3158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
acd6ddc to
3316e53
Compare
GregHolmes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No real big issues here! A broken json example, and the rest are comments. Let me know what you think.
| { | ||
| "name": "[meta]objects", | ||
| "data": { | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| { |
There's an extra { on this line.
| ## Subscribe to updates <a id="inband-objects-subscribe"/> | ||
|
|
||
| When using inband objects, the client will receive special `[meta]objects` messages whenever the objects on the channel are updated. These messages provide a snapshot of the current set of objects on the channel. | ||
| When using inband objects, the client will receive special `[meta]objects` messages whenever the objects on the channel are updated. The content of these messages depends on which mode you are using. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| When using inband objects, the client will receive special `[meta]objects` messages whenever the objects on the channel are updated. The content of these messages depends on which mode you are using. | |
| When using inband objects, the client will receive special `[meta]objects` messages whenever the objects on the channel are updated. The contents of these messages depends on which mode you are using. |
| ## Subscribe to updates <a id="inband-objects-subscribe"/> | ||
|
|
||
| When using inband objects, the client will receive special `[meta]objects` messages whenever the objects on the channel are updated. These messages provide a snapshot of the current set of objects on the channel. | ||
| When using inband objects, the client will receive special `[meta]objects` messages whenever the objects on the channel are updated. The content of these messages depends on which mode you are using. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to know what these contents are here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll remove this line. Everything is explained below it adds nothing.
|
|
||
| There are two inband modes available: | ||
|
|
||
| | Mode | Description | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | Mode | Description | | |
| | Mode | Description | | |
| | --- | --- | | |
| | `objects` | Sends the full state of all objects on the channel. | |
This isn't a big issue, but you don't need to fill to match the size of the table. The above would do for the first 3 lines of the table. MDX will render it correctly either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, my IDE insisted.
3316e53 to
41cc3be
Compare
Document the new `notification` inband mode for LiveObjects which notifies clients when objects operations are received without sending the full state data.
41cc3be to
b4bfcb1
Compare
We now stop sending inband object state sync if an object is over the max maessage size.
|
@GregHolmes Please could re-review I have updated the docs with some additional information a change that is due to be merged - 6e401e9 |
GregHolmes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kaschula , I've added a fixup for a couple sentence change and adding a sentence between headers.
All approved.
Just need to squash fixup (I'll keep it in place atm for you to read)
Thanks Greg, I have read them and it makes sense. Do you want me to do the rebase? I don't want to merge just yet till the fix rolls out in production next week. |
You're welcome to rebase to squash the fixup. |
I'll keep ownership and I will release it when the changes rollout. |
Summary
notificationinband mode for LiveObjectsChanges
New notification mode documentation:
notificationmode sends a notification when an objects operation is received (not just when state changes)linkproperty for fetching state via REST APIImproved objects mode documentation:
Updated mode comparison table:
objectsandnotificationmodesChecklist