[ABA-24] test(vortex-array): repro for decimal-array arithmetic dispatch rejection#16
Open
abnobdoss wants to merge 1 commit into
Open
[ABA-24] test(vortex-array): repro for decimal-array arithmetic dispatch rejection#16abnobdoss wants to merge 1 commit into
abnobdoss wants to merge 1 commit into
Conversation
…ejected at dispatch Add an `#[ignore]`'d regression test that documents the feature gap where `Binary::return_dtype` rejects arithmetic on `DType::Decimal` because it gates arithmetic on `is_primitive()`. Even a same-precision, same-scale, non-null decimal add is rejected before any kernel runs; there is no decimal arithmetic kernel in `scalar_fn::fns`. Test: `issue_aba24_decimal_array_add_same_scale_must_succeed` Repro-only — no fix in this commit. See: https://linear.app/abanoubdoss/issue/ABA-24 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Abanoub Doss <abnobdoss@proton.me> Signed-off-by: Abanoub Doss <abanoub.doss@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Binary::return_dtypeatvortex-array/src/scalar_fn/fns/binary/mod.rs:119-128gates all arithmetic onlhs.is_primitive().DType::Decimal(..)is never primitive, so every arithmetic call on decimal arrays — even same-precision, same-scale, no-null add/sub/mul/div — bails out before any kernel is invoked. There is no decimal arithmetic kernel inscalar_fn::fns.#[ignore]'d test (issue_aba24_decimal_array_add_same_scale_must_succeed) that reproduces the exact error (incompatible types for arithmetic operation: decimal(5,2) decimal(5,2)) and will flip to passing once the missing kernel lands.Test verification
Open questions for reviewers
scalar_fn::fns::binaryalongside primitive, or be lifted to a separate dispatcher (e.g. adecimalsub-module with its ownexecute_decimal)?s_out = s_lhs + s_rhs). Div is the hardest (precision loss, rounding). Should the first kernel target only same-scale add/sub, with mul/div deferred?Linear
https://linear.app/abanoubdoss/issue/ABA-24
🤖 Generated with Claude Code