[ABA-29] fix(vortex-runend): release-build sortedness validation in RunEnd::try_new#2
Open
abnobdoss wants to merge 2 commits into
Open
[ABA-29] fix(vortex-runend): release-build sortedness validation in RunEnd::try_new#2abnobdoss wants to merge 2 commits into
abnobdoss wants to merge 2 commits into
Conversation
…s validation is debug-only Demonstrates that RunEnd::try_new accepts unsorted ends arrays in release builds because the sortedness check is gated by #[cfg(debug_assertions)]. Linear: https://linear.app/abanoubdoss/issue/ABA-29 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Abanoub Doss <abanoub.doss@gmail.com>
…ebug_assertions Move the sortedness validation in RunEnd::try_new from #[cfg(debug_assertions)] to always run, so release builds reject malformed RunEnd arrays at construction. Linear: https://linear.app/abanoubdoss/issue/ABA-29 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Abanoub Doss <abanoub.doss@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Demonstrates and fixes ABA-29:
RunEnd::try_newsortedness validation is gated by#[cfg(debug_assertions)], so release builds accept malformed RunEnd arrays. Downstream compute paths later crash or silently return wrong data.encodings/runend/tests/issue_aba29_sortedness_release_check.rs(fails without the fix).#[cfg(debug_assertions)].Linear
https://linear.app/abanoubdoss/issue/ABA-29
Validation
cargo test -p vortex-runendpasses (new repro test + existing tests).cargo clippy -p vortex-runend --all-targetsclean.cargo +nightly fmt --all -- --checkclean.vortex-bug-hunt-72/tests/c18_runend_sortedness_debug_only.rs.🤖 Generated with Claude Code