[ABA-31] test(vortex-array): repro for missing string/unary/InList API surface#20
Open
abnobdoss wants to merge 1 commit into
Open
[ABA-31] test(vortex-array): repro for missing string/unary/InList API surface#20abnobdoss wants to merge 1 commit into
abnobdoss wants to merge 1 commit into
Conversation
…ps / native InList Add three #[ignore]d repro tests in `scalar_fn::fns::operators::tests` that document three independent API-surface gaps (REPRO-ONLY; no production code changed): - issue_aba31_a_general_string_scalar_function_exists: no length/upper/lower/ trim/concat/substring factories in expr::exprs or scalar_fn::fns modules - issue_aba31_b_unary_numeric_operator_exists: Operator enum (12 variants) covers only binary ops; no Abs/Neg/Floor/Ceil/Round/Sign/Sqrt exists - issue_aba31_c_native_in_list_operator_exists: SQL IN (...) is emulated via list_contains(lit(List[...]), x) in the DataFusion converter, conflating set membership with list-element-containment; no dedicated InList scalar fn Each test panics with a diagnostic message when run with --ignored. A control test confirms the discovery harness is functional. Fixes: https://linear.app/abanoubdoss/issue/ABA-31 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Abanoub Doss <abnobdoss@proton.me> Signed-off-by: Abanoub Doss <abanoub.doss@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repro-only PR — no production code changed. Adds three
#[ignore]d tests invortex-array/src/scalar_fn/fns/operators.rsthat document three independentAPI-surface gaps tracked under ABA-31:
scalar_fn::fnshas no modulefor
length,upper,lower,trim,substring,concat, etc. The onlystring-shaped op is
like. Test:issue_aba31_a_general_string_scalar_function_existsOperatorenum (12 variants) covers onlybinary ops. No
Abs,Neg,Floor,Ceil,Round,Sign, orSqrtvariant exists. An exhaustive
matchin the test acts as a compile-time tripwire: if a unary variant is ever added, the match stops compiling. Test:
issue_aba31_b_unary_numeric_operator_existsIN (...)is emulated in the DataFusionconverter as
list_contains(lit(List[...]), x), conflating relational set-membershipwith list-element-containment and preventing stat-based falsification. Test:
issue_aba31_c_native_in_list_operator_existsEach of the three gaps is independent and a separate future feature addition.
A control test (
control_list_contains_id_is_stable) verifies the discoveryharness is functional.
Linear: https://linear.app/abanoubdoss/issue/ABA-31
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Generated with Claude Code