Accept legacy PyPI local versions like 2.0.1rc2-git#179
Open
Adityakk9031 wants to merge 1 commit intoaboutcode-org:mainfrom
Open
Accept legacy PyPI local versions like 2.0.1rc2-git#179Adityakk9031 wants to merge 1 commit intoaboutcode-org:mainfrom
Adityakk9031 wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
Signed-off-by: Aditya kumar singh <143548997+Adityakk9031@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a safe fallback for legacy local versions that use - by normalizing to PEP 440 +.
Keep strict packaging.version.Version as the primary parser.
Add tests to cover the new behavior.
Changes
versions.py: add fallback normalization for legacy local versions.
test_pypi_version.py: new test for 2.0.1rc2-git.
test_versions.py: validate is_valid() accepts the legacy form.
Testing
pytest -q
test_pypi_version.py -q (optional)
Issue
Fixes #176