[DQT] Fix terminology and labels in Add Condition modal#10504
Open
HachemJ wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
Module: dataquery
fias06
added
the
Passed manual tests
|
LGTM! |
driusan
reviewed
Jun 11, 2026
|
|
||
| criteriaSelect = <div> | ||
| <h3>{t('Criteria', {ns: 'dataquery'})}</h3> | ||
| <h4 style={{color: '#003d68', fontWeight: 'normal'}}> |
Collaborator
There was a problem hiding this comment.
This font/colour change seems to be arbitrary and inconsistent with the rest of LORIS. git grep -i '#003d68' doesn't find any other instances of it in LORIS anywhere.
The ticket #10124 just complains about the wording, so I'm not sure why you're changing the styling
driusan
reviewed
Jun 11, 2026
| throwWarning={true} | ||
| onClose={props.closeModal} | ||
| onSubmit={submitPromise}> | ||
| <Modal title={<span style={{color: '#003d68'}}> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased replacement for #10305 onto 28.0-release.