Merged
Conversation
…cp-30-generate-typechain-types-in-sdk-repo
fusmanii
requested review from
bmzig,
dijanin-brat and
pxrl
and removed request for
dijanin-brat
…cp-30-generate-typechain-types-in-sdk-repo
tbwebb22
reviewed
Feb 4, 2026
tbwebb22
left a comment
tbwebb22
left a comment
There was a problem hiding this comment.
LGTM, just one question
src/utils/Multicall.ts still has:
import { Multicall3, Multicall3__factory } from "./abi/typechain";
should this be updated?
grasphoper
reviewed
Feb 5, 2026
…cp-30-generate-typechain-types-in-sdk-repo
Contributor
Author
@tbwebb22 that can stay as is since the build step will generate the types |
tbwebb22
approved these changes
Feb 6, 2026
grasphoper
approved these changes
Feb 7, 2026
…cp-30-generate-typechain-types-in-sdk-repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.