Open
Conversation
Owner
|
package_json.lua的格式全乱了 |
actboy168
requested changes
Mar 17, 2023
Owner
|
由launcher加载调试器dll的代码也可以包含进来，这很有用。 |
Contributor
Author
设置中保存自动format,我先添加一个pull来完成code-format的功能把现有的lua文件都format一遍 |
Owner
|
format是个大工程，尤其是在lua 的format还不是很成熟的情况下。所以你还是先别改吧。 |
Contributor
Author
嗯,就先启用设置,保证以后format的结果 |
Contributor
Author
|
把我搞懵了,package_json.lua文件用的是windows的换行符号,怪不得一format整个文件变了,你是如何打算的,统一使用哪种? |
Contributor
Author
单纯加载调试器?还是要把导入表修复的部分也加入? |
Owner
|
只加载就好 |
Owner
用lf吧，我记得我的git配置是会强制转为lf的 |
Contributor
Author
主干上直接format成lf吧,pull里就不做这个操作了 |
# Conflicts: # src/launcher/autoattach/autoattach.cpp
actboy168
requested changes
Apr 6, 2023
Co-authored-by: actboy168 <actboy168@gmail.com>
actboy168
requested changes
Apr 6, 2023
actboy168
requested changes
Apr 6, 2023
fesily
commented
Apr 7, 2023
actboy168
requested changes
Apr 7, 2023
Contributor
Author
|
最近在忙其他的,review咋样,还有需要哪里改进的吗 @actboy168 |
Owner
|
我最近也挺忙的，所以还没空review |
Contributor
Author
好的,等你忙完 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signature两个配置module和version,module需要用户填写,version自动从luaVersion字段读取
将attach的luaversion默认设置为unknown,允许launcher自动判断版本
将luadbug和launcher添加为module黑名单将调试器目录下的所有module为黑名单