chart: add topologySpreadConstraints defaults#4526
Draft
ChongZhe001025 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing
topologySpreadConstraintsdefaults to the legacyactions-runner-controllerchart values.The chart templates and README already support topology spread constraints for:
However, the corresponding default entries were missing from
charts/actions-runner-controller/values.yaml, unlike similar scheduling-related fields such asnodeSelector,tolerations, andaffinity.Context
Refs #4097.
While investigating the issue, I found that the templates already render:
.Values.topologySpreadConstraints.Values.githubWebhookServer.topologySpreadConstraints.Values.actionsMetricsServer.topologySpreadConstraintsThe README also documents these values, so this change only adds the missing defaults to
values.yamlfor consistency and discoverability.Changes
topologySpreadConstraints: []githubWebhookServer.topologySpreadConstraints: []actionsMetricsServer.topologySpreadConstraints: []Testing
git diff --checkhelm templatefor the controller topology spread constraintshelm templateforgithubWebhookServer.topologySpreadConstraintshelm templateforactionsMetricsServer.topologySpreadConstraints