updating the runner logs to output the workflow run ID#4508
Open
petercort wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds richer job start logging by including the workflow run ID, and introduces a helper to read values from the github context with L0 coverage.
Changes:
- Extend job start log line to include Job ID and workflow run ID.
- Add
GetGitHubContextValuehelper for extractinggithub.<key>fromContextData. - Add L0 tests for present/missing context and key scenarios.
Show a summary per file
| File | Description |
|---|---|
| src/Runner.Listener/JobDispatcher.cs | Adds helper to read github context values and logs workflow run ID when starting a job. |
| src/Test/L0/Listener/JobDispatcherL0.cs | Adds unit tests covering GetGitHubContextValue behavior for present/missing github context/key. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 3
Comment on lines
+734
to
+746
| internal static string GetGitHubContextValue(Pipelines.AgentJobRequestMessage message, string key) | ||
| { | ||
| if (message.ContextData != null && | ||
| message.ContextData.TryGetValue("github", out var githubContext) && | ||
| githubContext is DictionaryContextData githubContextData && | ||
| githubContextData.TryGetValue(key, out var value) && | ||
| value is StringContextData stringValue) | ||
| { | ||
| return stringValue.Value; | ||
| } | ||
|
|
||
| return "unknown"; | ||
| } |
Comment on lines
+734
to
+737
| internal static string GetGitHubContextValue(Pipelines.AgentJobRequestMessage message, string key) | ||
| { | ||
| if (message.ContextData != null && | ||
| message.ContextData.TryGetValue("github", out var githubContext) && |
| return stringValue.Value; | ||
| } | ||
|
|
||
| return "unknown"; |
petercort
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outputs the workflow run ID in the logs so users can correlate to a specific job run. Currently only the name exists, which doesn't tell which run ran.
Example output: