Skip to content

Fix audiomixer.Mixer regressions on SAMD51 #10906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
relic-se wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix audiomixer.Mixer regressions on SAMD51 #10906

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce2d6e9
Remove unused inline functions
relic-se Mar 30, 2026
9c763ba
Add ARM operations for 16-bit copy functions
relic-se Mar 30, 2026
8fcd823
Remove extra tokens from #endif directives
relic-se Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions shared-module/audiomixer/Mixer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,23 +156,21 @@ static inline uint32_t pack8(uint32_t val) {
}

static inline uint32_t copy16lsb(uint32_t val) {
#if (defined(__ARM_ARCH_7EM__) && (__ARM_ARCH_7EM__ == 1))
return __PKHBT(val, val, 16);
#else
val &= 0x0000ffff;
return val | (val << 16);
#endif
}

static inline uint32_t copy16msb(uint32_t val) {
#if (defined(__ARM_ARCH_7EM__) && (__ARM_ARCH_7EM__ == 1))
return __PKHTB(val, val, 16);
#else
val &= 0xffff0000;
return val | (val >> 16);
}

static inline uint32_t copy8lsb(uint32_t val) {
val &= 0x00ff;
return val | (val << 8);
}

static inline uint32_t copy8msb(uint32_t val) {
val &= 0xff00;
return val | (val >> 8);
#endif
}

#define ALMOST_ONE (MICROPY_FLOAT_CONST(32767.) / 32768)
Expand Down
Loading