fix: use correct DM delivery URLs per asset MIME type by actinium15 · Pull Request #832 · adobe/da-live

actinium15 · 2026-03-09T14:44:43Z

Summary

Documents (PDF, DOCX, CSV, ZIP) now route to /original instead of the web-optimized image delivery URL (/as/{name})
Videos route to /play by default
Both behaviours are configurable per-project: set aem.asset.document.mimetypes in the project config to a comma-separated list of MIME types that should use /original (overrides the defaults entirely, including for video MIME types if listed)

Routing logic (DM delivery mode)

Asset type	URL suffix
MIME type in `useOriginalMimetypes`	`/original`
`video/*` (not in above list)	`/play`
Everything else (images, etc.)	`/as/{name}`

Default `aem.asset.document.mimetypes`

application/pdf
application/vnd.openxmlformats-officedocument.wordprocessingml.document
text/csv
application/zip

Test plan

Select a PDF asset — verify URL ends with /original
Select a DOCX asset — verify URL ends with /original
Select a ZIP asset — verify URL ends with /original
Select a video asset — verify URL ends with /play
Select an image asset — verify URL ends with /as/{name}
Set aem.asset.document.mimetypes to video/mp4 in project config — verify MP4 asset URL ends with /original

Documents (PDF, DOCX, CSV, ZIP) now use /original instead of the web-optimized image delivery URL. Videos use /play by default. Both are configurable per-project via 'aem.asset.document.mimetypes'.

actinium15 · 2026-03-09T14:57:08Z

@sagarsane, @andreas-haller, could you please take a look?

I'm esp interested in knowing if the changes you intended to add via #806 are accounted for or not (they should be imo).

sagarsane · 2026-03-09T17:22:01Z

 const ASSET_SELECTOR_URL = 'https://experience.adobe.com/solutions/CQ-assets-selectors/static-assets/resources/assets-selectors.js';

+// MIME types that use /original rendition instead of web-optimized or /play delivery.
+// Configurable per-project via 'aem.asset.document.mimetypes' (comma-separated).


@auniverseaway @chrischrischris I'm thinking we probably don't need to configure this per project .. and by default only support whatever Dynamic Media OpenAPI supports (which is the list below). WDYT?

I think we should have that config. two reasons:

the list isn't comprehensive since assets beyond these four may also require original download (pptx, doc, txt, ...) and DM with OpenAPI does support them

videos are interesting, because while /play is ideal, some customers may want to use mediabus to deliver mp4s and may require original there (and this can serve as an override)

- Original rendition: /original/as/{name} (was missing /as/{name}) - Web-optimized: /as/{baseName}.avif, always avif with extension stripped

ravuthu · 2026-03-11T14:21:40Z

+      return `${getBaseDmUrl(asset)}/original/as/${encodedName}`;
+    }
+    if (mimeType?.startsWith('video/')) {
+      return `${getBaseDmUrl(asset)}/play`;


When the author repository is configured for the asset selector, it's not guaranteed that the DM OpenAPI is enabled for the project, and /play endpoint may not be available, as I understand. @actinium15 thoughts?

author repository is configured for the asset selector, it's not guaranteed that the DM OpenAPI is enabled for the project, and /play endpoint may not be available, as I understand

your understanding is correct.
afaict, author-repo flow ends a L140 with a return in if (!dmDeliveryEnabled) {} block. the .play endpoint changes are thus only applicable when dmDeliveryEnabled=true.

apologies if I'm going blind and missing something obvious here, @ravuthu

@actinium15 The use case is that some customers choose the author Repo to have the folder structure even though the DM delivery is enabled.

some customers choose the author Repo to have the folder structure even though the DM delivery is enabled

as long as the code's generating urls that start with getBaseDmUrl (which the original code was doing as well here), the author/delivery/... repo won't matter.

If I understood the code correctly, dmDeliveryEnabled == true does not really mean that DM is enabled, but it means that the customer said they want to use the delivery tier.

To be 100% sure DM is enabled, is it possible to call the Discovery Service /index endpoint? In such a case, the Discovery Service returns "dmopenapi" as a value for "aem:solutions" property when Dynamic Media is enabled.

dmDeliveryEnabled == true does not really mean that DM is enabled

the current code (outside the context of this PR) switches completely to generating DM Urls when dmDeliveryEnabled==true.

is it possible to call the Discovery Service /index endpoint?

@pablomoreno61, are you suggesting that the assumption made in the code that's on mainline today is wrong?

My understanding is that dmDeliveryEnabled is set in
const dmDeliveryEnabled = smartCropSelectEnabled || (await getConfKey(owner, repo, 'aem.asset.dm.delivery')) === 'on' || prodOrigin?.startsWith('delivery-');

I'm not knowledgeable about this repo, so take my opinion with a grain of salt. In that line of code, we are reading the properties set by the customer in their DA config file, right? If there is no previous validation, we are just "trusting" the input from the customer, but in the end, Dynamic Media could still be disabled for the AEM repository they targeted if they did not manually enable DM within AEM Experience Manager Cloud.

@ravuthu, @sagarsane, the behaviour @pablomoreno61 notes (if valid) predates this changeset.

would you agree? if so, perhaps a candidate to address in a followup PR and move ahead with this changeset?

wdyt?

ravuthu · 2026-03-16T21:23:51Z

These are being discussed and taken care of on #841.

@auniverseaway, can you close this PR please?

ravuthu

Changes look good to me.

auniverseaway

Thanks @ravuthu & @sagarsane!

fix: use correct DM delivery URLs per asset MIME type

f87462f

Documents (PDF, DOCX, CSV, ZIP) now use /original instead of the web-optimized image delivery URL. Videos use /play by default. Both are configurable per-project via 'aem.asset.document.mimetypes'.

sagarsane reviewed Mar 9, 2026

View reviewed changes

Comment thread blocks/edit/da-assets/da-assets.js Outdated

sagarsane reviewed Mar 9, 2026

View reviewed changes

actinium15 added 2 commits March 9, 2026 23:02

fix: correct DM delivery URL formats per OpenAPI spec

1ff7d2b

- Original rendition: /original/as/{name} (was missing /as/{name}) - Web-optimized: /as/{baseName}.avif, always avif with extension stripped

fix: encode asset name in DM delivery URLs

20a9959

ravuthu suggested changes Mar 11, 2026

View reviewed changes

andreas-haller mentioned this pull request Mar 16, 2026

refactor: Modularize AEM Asset Selector into testable helpers with explicit repository mode support #841

Merged

10 tasks

ravuthu approved these changes Mar 19, 2026

View reviewed changes

Merge branch 'main' into fix/da-assets-dm-delivery-url-routing

740f434

auniverseaway approved these changes Mar 19, 2026

View reviewed changes

auniverseaway merged commit 8cdfac7 into adobe:main Mar 19, 2026
3 of 4 checks passed

Conversation

actinium15 commented Mar 9, 2026

Summary

Routing logic (DM delivery mode)

Default aem.asset.document.mimetypes

Test plan

Uh oh!

actinium15 commented Mar 9, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ravuthu commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ravuthu left a comment

Choose a reason for hiding this comment

Uh oh!

auniverseaway left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Default `aem.asset.document.mimetypes`

ravuthu commented Mar 16, 2026 •

edited

Loading