fix: #10182 fixed the table keyboard navigation in the scrollIntoViewport #10211
Open
jsmitrah wants to merge 11 commits into
Open
fix: #10182 fixed the table keyboard navigation in the scrollIntoViewport #10211jsmitrah wants to merge 11 commits into
jsmitrah wants to merge 11 commits into
Conversation
jsmitrah
changed the title
jsmitrah
changed the title
nwidynski
reviewed
Jun 16, 2026
| let shouldCenter = true; | ||
| if (containingElement) { | ||
| const containerRect = containingElement.getBoundingClientRect(); | ||
| if (containerRect.height > window.innerHeight) { |
Contributor
There was a problem hiding this comment.
Please see #10182 (comment). We shouldn't skip merely based on dimensions.
Author
There was a problem hiding this comment.
Thanks @nwidynski, I have updated my code to handle scrolling based on dimensions.
…crollIntoViewport-componen
Author
|
Hi @nwidynski , can you please check my PR and let me know if any changes are needed. |
Contributor
|
The problem I mentioned in the last comment is still unaddressed. The container may be obscured by another scrollParent, so directly comparing its bounding rect against the viewport doesn't work reliably. |
…crollIntoViewport-componen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10182
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: