docs(ComboBox): document defaultFilter's default contains filter#10222
Open
patrickwehbe wants to merge 3 commits into
Open
docs(ComboBox): document defaultFilter's default contains filter#10222patrickwehbe wants to merge 3 commits into
patrickwehbe wants to merge 3 commits into
Conversation
snowystinger
approved these changes
Jun 18, 2026
Member
|
Looks like you need to sign the CLA. https://github.com/adobe/react-spectrum/blob/main/CONTRIBUTING.md#contributor-license-agreement Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Closes #10065
Description
The React Aria Components
ComboBox'sdefaultFilterprop didn't document its default, so the generated props table gave no hint about what filtering happens out of the box. As confirmed in the issue, whendefaultFilterisn't provided the component falls back to thecontainsfilter fromuseFilter(defaultFilter: props.defaultFilter || contains).This documents that default in the prop's JSDoc, and fixes a small grammar slip in the same comment ("if a option" → "if an option").