chore: fix React Aria home page "bring your styles" button in light mode#10242
chore: fix React Aria home page "bring your styles" button in light mode#10242LFDanLu wants to merge 3 commits into
Conversation
|
Build successful! 🎉 |
| ); | ||
| } | ||
|
|
||
| export function RACSettingsProvider({children}: Pick<SettingsProviderProps, 'children'>) { |
There was a problem hiding this comment.
The SettingsProvider renders an extra S2 Provider that adds a div with isolation: isolate which seems to break the tab styling. However, this actually didn't fix the "Explore Components" button hmm
|
Build successful! 🎉 |
|
Build successful! 🎉 |
| variant: { | ||
| primary: 'auto', | ||
| secondary: 'white', | ||
| secondary: { |
There was a problem hiding this comment.
So now we need to do an actual release for this code change, it's not just docs? What happened here?
There was a problem hiding this comment.
I messed up the styles and our chromatic didn't catch them. I'd originally gone this route, but ran into Error evaluating macro: transparent-overlay-1000 does not support states and wrongly decided that just going with a static value like the others would work. I didn't test it against enough backgrounds.
There was a problem hiding this comment.
specifically i messed it up prior to the last release, so this is pre-existing at the moment
73bc1db
4 participants
from testing
✅ Pull Request Checklist:
📝 Test Instructions:
Test the React Aria home page in light and dark mode. The tabs under "Bring your own styles" should render properly in both
🧢 Your Project:
RSP