Skip to content

fix: resolve canonical URL before RUM lookup during PLG onboarding#1970

Merged
Kanishkavijay39 merged 6 commits intomainfrom
plg-rum-fix
Mar 19, 2026
Merged

fix: resolve canonical URL before RUM lookup during PLG onboarding#1970
Kanishkavijay39 merged 6 commits intomainfrom
plg-rum-fix

Conversation

@Kanishkavijay39
Copy link
Copy Markdown
Contributor

Moves overrideBaseURL resolution ahead of autoResolveAuthorUrl so that sharedWwwUrlResolver uses the canonical hostname (e.g. www.example.com) when querying RUM, fixing cases where the bare domain has no RUM domainkey.

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description. Or if there's no issue created, make sure you
    describe here the problem you're solving.
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

If the PR is changing the API specification:

  • make sure you add a "Not implemented yet" note the endpoint description, if the implementation is not ready
    yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
  • make sure you add at least one example of the request and response.

If the PR is changing the API implementation or an entity exposed through the API:

  • make sure you update the API specification and the examples to reflect the changes.

If the PR is introducing a new audit type:

  • make sure you update the API specification with the type, schema of the audit result and an example

Related Issues

Thanks for contributing!

Moves overrideBaseURL resolution ahead of autoResolveAuthorUrl so that
sharedWwwUrlResolver uses the canonical hostname (e.g. www.example.com)
when querying RUM, fixing cases where the bare domain has no RUM domainkey.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 17, 2026

This PR will trigger a minor release when merged.

Kanishka and others added 3 commits March 19, 2026 23:23
…e audit trigger from fast-track

- profiles.json: add auto-fix/auto-suggest handlers to aso_plg profile
- plg-onboarding: remove triggerAudits call from PRE_ONBOARDING fast-track path
  (audits already triggered during preonboarding script run)
- tests: update fast-track assertions to reflect removed audit trigger
@Kanishkavijay39 Kanishkavijay39 merged commit e468ce2 into main Mar 19, 2026
18 checks passed
@Kanishkavijay39 Kanishkavijay39 deleted the plg-rum-fix branch March 19, 2026 18:41
solaris007 pushed a commit that referenced this pull request Mar 19, 2026
## [1.358.1](v1.358.0...v1.358.1) (2026-03-19)

### Bug Fixes

* resolve canonical URL before RUM lookup during PLG onboarding ([#1970](#1970)) ([e468ce2](e468ce2))
@solaris007
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.358.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants