feat: support boolean and timestamp for edgeOptimizeConfig.enabled#1441
Merged
jindaliiita merged 2 commits intomainfrom Mar 17, 2026
Merged
feat: support boolean and timestamp for edgeOptimizeConfig.enabled#1441jindaliiita merged 2 commits intomainfrom
jindaliiita merged 2 commits intomainfrom
Conversation
|
This PR will trigger a patch release when merged. |
nit23uec
approved these changes
Mar 16, 2026
jindaliiita
added a commit
to adobe/spacecat-api-service
that referenced
this pull request
Mar 17, 2026
…mp (#1961) ## Summary Update OpenAPI schema for `EdgeOptimizeConfig` to reflect support for both boolean and timestamp (number) types for the `enabled` field. ## Changes - Updated `docs/openapi/schemas.yaml` to use `oneOf` for dual-type support - Updated schema description to clarify use cases ## Use Cases - **Boolean**: `enabled: true/false` - Flag to enable/disable edge optimization - **Timestamp**: `enabled: 1772531669121` - Store timestamp (milliseconds since epoch) of when edge optimization was enabled for the site ## Schema Example ```yaml enabled: description: Whether edge optimize is enabled. Can be boolean flag or timestamp. oneOf: - type: boolean example: true - type: number example: 1772531669121 ``` ## Related - Depends on: adobe/spacecat-shared#1441 (schema validation in data-access layer) 🤖 Generated with Claude Code --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
solaris007
pushed a commit
that referenced
this pull request
Mar 17, 2026
## [@adobe/spacecat-shared-data-access-v3.22.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v3.21.0...@adobe/spacecat-shared-data-access-v3.22.0) (2026-03-17) ### Features * support boolean and timestamp for edgeOptimizeConfig.enabled ([#1441](#1441)) ([2fb173d](2fb173d))
Member
|
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v3.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
edgeOptimizeConfig.enabledfield to accept both boolean and number (timestamp) types.Changes
Joi.alternatives()accepting bothJoi.boolean()andJoi.number()Use Cases
enabled: true/false- Flag to enable/disable edge optimizationenabled: 1772531669121- Store timestamp (milliseconds since epoch) of when edge optimization was enabled for the siteExample
Testing
🤖 Generated with Claude Code