Fix update-release-version.sh for explicit pack version updates#353
Merged
data-douser merged 2 commits intomainfrom Mar 31, 2026
Merged
Fix update-release-version.sh for explicit pack version updates#353data-douser merged 2 commits intomainfrom
update-release-version.sh for explicit pack version updates#353data-douser merged 2 commits intomainfrom
Conversation
Fixes the update-release-version.sh script to update CodeQL pack dependency versions in sync with CodeQL CLI version when a pack dependency points to an explicit pack version vice a semver range or (greater than) caret. Fixes the cause of the version mismatch fixed by PR #352.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates scripts/update-release-version.sh so internal CodeQL pack dependency versions are bumped reliably even when qlpack.yml uses quoted keys and/or quoted exact version strings (not just caret ranges).
Changes:
- Expand
update_internal_deps()to also update exact quoted versions ("2.3.0" -> "2.4.0"). - Make internal dependency key matching tolerant of quoted vs unquoted pack names.
- Update in-script documentation/comments to reflect the supported YAML formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the update-release-version.sh script to update CodeQL pack dependency versions in sync with CodeQL CLI version when a pack dependency points to an explicit pack version vice a semver range or (greater than) caret.
Fixes the cause of the version mismatch fixed by PR #352.
What This PR Contributes
Improvements to dependency version updating:
update_internal_deps()function to update dependencies regardless of whether the pack name or version is quoted or unquoted, covering all YAML key-value formats found inqlpack.ymlfiles. [1] [2]Future Works