Skip to content

CLIENT-4543 remove get with no params from grammar #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gagan405 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CLIENT-4543 remove get with no params from grammar #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7b0fb3
remove get with no params from grammar
gagan405 Mar 30, 2026
db67d79
support `get()` with no params, add unit test
gagan405 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/main/java/com/aerospike/dsl/visitor/ExpressionConditionVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,12 +776,15 @@ public AbstractPart visitIntLogicalRShiftExpression(ConditionParser.IntLogicalRS
public AbstractPart visitPathFunctionGet(ConditionParser.PathFunctionGetContext ctx) {
PathFunction.ReturnParam returnParam = null;
Exp.Type binType = null;
for (ConditionParser.PathFunctionParamContext paramCtx : ctx.pathFunctionParams().pathFunctionParam()) {
if (paramCtx != null) {
String typeVal = getPathFunctionParam(paramCtx, "type");
if (typeVal != null) binType = Exp.Type.valueOf(typeVal);
String returnVal = getPathFunctionParam(paramCtx, "return");
if (returnVal != null) returnParam = PathFunction.ReturnParam.valueOf(returnVal);
ConditionParser.PathFunctionParamsContext params = ctx.pathFunctionParams();
if (params != null) {
for (ConditionParser.PathFunctionParamContext paramCtx : params.pathFunctionParam()) {
if (paramCtx != null) {
String typeVal = getPathFunctionParam(paramCtx, "type");
if (typeVal != null) binType = Exp.Type.valueOf(typeVal);
String returnVal = getPathFunctionParam(paramCtx, "return");
if (returnVal != null) returnParam = PathFunction.ReturnParam.valueOf(returnVal);
}
}
}
return new PathFunction(PathFunction.PathFunctionType.GET, returnParam, binType);
Expand Down
1 change: 1 addition & 0 deletions src/test/java/com/aerospike/dsl/expression/BinExpressionsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ void binNotEquals() {
parseFilterExpressionAndCompare(ExpressionContext.of("$.intBin1 != 100"), Exp.ne(Exp.intBin("intBin1"), Exp.val(100)));
parseFilterExpressionAndCompare(ExpressionContext.of("$.strBin != \"yes\""), Exp.ne(Exp.stringBin("strBin"), Exp.val("yes")));
parseFilterExpressionAndCompare(ExpressionContext.of("$.strBin != 'yes'"), Exp.ne(Exp.stringBin("strBin"), Exp.val("yes")));
parseFilterExpressionAndCompare(ExpressionContext.of("$.intBin1.get() != 100"), Exp.ne(Exp.intBin("intBin1"), Exp.val(100)));
}

@Test
Expand Down
Loading