Render commands and friends#1830
Open
universalconquistador wants to merge 19 commits into
Open
Conversation
| [MemberFunction("48 89 5C 24 ?? 48 89 6C 24 ?? 56 57 41 54 41 56 41 57 48 83 EC 50 44 8B 05")] | ||
| public partial ulong Draw(bool unk); | ||
|
|
||
| [MemberFunction("E9 ?? ?? ?? ?? CC CC CC CC CC CC CC CC CC CC 48 89 5C 24 ?? 48 89 6C 24 ?? 48 89 7C 24 ?? 41 56")] |
Contributor
Author
There was a problem hiding this comment.
Yes I realize this is a terrible signature, let me know if you have any better ideas for how to do this!
github-actions
Bot
added
the
breaking change
Contributor
Author
I believe basically none of these changed render command fields were correct? So I think we're good to make these breaking changes. |
|
|
||
| [StructLayout(LayoutKind.Explicit, Size = 0x40)] | ||
| public unsafe struct TextureMipRenderTarget { | ||
| [FieldOffset(0x00)] public void* D3D11RenderTargetViewOrDepthStencilView; // ID3D11RenderTargetView(1?) or ID3D11DepthStencilView(1?) |
Contributor
Author
There was a problem hiding this comment.
I bet we could use a CExporterUnion here to present both the ID3D11RenderTargetView* and the ID3D11DepthStencilView*
Caraxi
reviewed
May 20, 2026
Caraxi
reviewed
May 20, 2026
Collaborator
Haselnussbomber
left a comment
Haselnussbomber
left a comment
There was a problem hiding this comment.
Pushed some changes, but other than that it looks fine to me.
| public static partial Device* Instance(); | ||
|
|
||
| [FieldOffset(0x8)] public void* ContextArray; // Client::Graphics::Kernel::Context array | ||
| [FieldOffset(0x8)] public void* ContextArray; // TODO: We have a struct for this now (breaking change) |
Collaborator
There was a problem hiding this comment.
Just as a note, I would have no idea what to change this to. I guess Context* something?
Would rather add a Span for that if the size is constant and the length is known.
Contributor
Breaking ChangesMember exists in left but not in rightFFXIVClientStructs.FFXIV.Client.Graphics.Kernel: 1RenderCommandClearDepth: 1
|
sourpuh
reviewed
Jun 2, 2026
Comment on lines
+87
to
+91
| [MemberFunction("E8 ?? ?? ?? ?? 48 8B 7B 18 45 33 FF")] | ||
| public partial void ProcessCommands(RenderCommandBufferGroup* renderCommands, uint renderCommandCount); | ||
|
|
||
| [MemberFunction("E8 ?? ?? ?? ?? 48 8B 7B 18 45 33 FF")] | ||
| public partial void PreprocessCommands(RenderCommandBufferGroup* renderCommands, uint renderCommandCount); |
Contributor
There was a problem hiding this comment.
Process and Preprocess have the same sig?
sourpuh
reviewed
Jun 2, 2026
| public partial void* AllocateCommand(ulong size); | ||
|
|
||
| [MemberFunction("4C 8B C9 4D 8D 50 0F")] | ||
| public partial void* AllocateSpecificCommand(int commandType, ulong size); |
Contributor
There was a problem hiding this comment.
Should commandType use the enum?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few different rendering things in support of under-UI overlay drawing: