Remove early return from set_cursor_tuple_fraction#63
Open
xathien wants to merge 1 commit intoafair:masterfrom
Open
Remove early return from set_cursor_tuple_fraction#63xathien wants to merge 1 commit intoafair:masterfrom
set_cursor_tuple_fraction#63xathien wants to merge 1 commit intoafair:masterfrom
Conversation
The early return removed the ability to override Postgres' default fraction of `0.1` with `1.0`. A workaround was to use `0.99999` but that's a little bit ugly, so let's just always set the tuple fraction. Alternatively, we could check the current fraction on the `@connection` and only change it if it's different, which would also allow us to revert the temporary fraction change afterward, but that's an adjustment for another PR. Partially fixes afair#49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The early return removed the ability to override Postgres' default fraction of
0.1with1.0. A workaround was to use0.99999but that's a little bit ugly, so let's just always set the tuple fraction.Alternatively, we could check the current fraction on the
@connectionand only change it if it's different, which would also allow us to revert the temporary fraction change afterward, but that's an adjustment for another PR.Partially fixes #49