Remove pcfsoft shadow type, deprecated in r182, pcf is now soft as well#5798
Open
vincentfretin wants to merge 1 commit intoaframevr:masterfrom
Open
Remove pcfsoft shadow type, deprecated in r182, pcf is now soft as well#5798vincentfretin wants to merge 1 commit intoaframevr:masterfrom
vincentfretin wants to merge 1 commit intoaframevr:masterfrom
Conversation
Contributor
|
Perhaps we can add a generic fallback in |
Contributor
Author
|
Right, the warning on threejs side |
…ll, show a warning about shadow type not supported and fall back to pcf
vincentfretin
force-pushed
the
remove-pcfsoft
branch
from
05388ec to
5b52a29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Remove pcfsoft shadow type, deprecated in r182, pcf is now soft as well.
You should wait for three to be updated to r182+ before merging this.
Changes proposed: