Make irrelevant-recompute and corollaries unsafe#3012
Open
jespercockx wants to merge 1 commit into
Open
Conversation
… module with --irrelevant-projections flag
Collaborator
|
I guess we'll only bring ⊥-recompute : Recomputable ⊥
⊥-recompute ()and hence its corollary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the less invasive alternative to #2998, which instead just makes the definitions that are no longer supported unsafe by putting them in a separate
Unsafemodule that has the--irrelevant-projectionsflag.Currently this is based on the
experimentalbranch, which seems to lag a bit behind onmaster. I tried to bring it up to date but got a bunch of merge conflicts that I didn't know how to solve immediately. If someone else could bring the experimental branch up to date, I'd be glad to rebase this PR on it.TODO: